Bug in dc-tool

If you have any questions on programming, this is the place to ask them, whether you're a newbie or an experienced programmer. Discussion on programming in general is also welcome. We will help you with programming homework, but we will not do your work for you! Any porting requests must be made in Developmental Ideas.
Post Reply
Chilly Willy
DC Developer
DC Developer
Posts: 414
Joined: Thu Aug 20, 2009 11:00 am
Has liked: 0
Been liked: 2 times

Bug in dc-tool

Post by Chilly Willy » Sun Jun 12, 2016 3:01 pm

I think I found a bug in dc-tool. In syscalls.c in dc_cdfs_redir_read_sectors(), buf is allocated but never freed. In the other functions that allocate a buffer, it's freed before returning.

This was in dcload-ip; I imagine dcload has the same issue with dc-tool.
User avatar
BlueCrab
The Crabby Overlord
The Crabby Overlord
Posts: 5393
Joined: Mon May 27, 2002 11:31 am
Location: Sailing the Skies of Arcadia
Has liked: 1 time
Been liked: 12 times
Contact:

Re: Bug in dc-tool

Post by BlueCrab » Tue Jun 14, 2016 12:52 pm

Fixed (in both dcload-serial and dcload-ip).
Chilly Willy
DC Developer
DC Developer
Posts: 414
Joined: Thu Aug 20, 2009 11:00 am
Has liked: 0
Been liked: 2 times

Re: Bug in dc-tool

Post by Chilly Willy » Wed Jun 15, 2016 12:42 pm

Cool, thanks. At least that was an easy one. :)
User avatar
BlueCrab
The Crabby Overlord
The Crabby Overlord
Posts: 5393
Joined: Mon May 27, 2002 11:31 am
Location: Sailing the Skies of Arcadia
Has liked: 1 time
Been liked: 12 times
Contact:

Re: Bug in dc-tool

Post by BlueCrab » Wed Jun 15, 2016 6:35 pm

Chilly Willy wrote:Cool, thanks. At least that was an easy one. :)
Very much so. Thanks for reporting it.
Post Reply