sq_cpy and pvr_scene_begin_txr

[bogglez]

Two quick questions:

- Why is the src argument in void * sq_cpy(void *dest, void *src, int n) not const? Can sq_cpy change src?
- Why does void pvr_scene_begin_txr(pvr_ptr_t txr, uint32 *rx, uint32 *ry) take pointers as arguments? Is something written back to them? I assumed by value passing at first.

[BlueCrab]

Two quick questions:

- Why is the src argument in void * sq_cpy(void *dest, void *src, int n) not const? Can sq_cpy change src?

No, it can not. It should be const, but it was traditionally not so. I'll probably change that at some point (as well as making n a size_t instead of an int, since it should never be negative), but as I said, that is not how it was originally written for whatever reason.

- Why does void pvr_scene_begin_txr(pvr_ptr_t txr, uint32 *rx, uint32 *ry) take pointers as arguments? Is something written back to them? I assumed by value passing at first.

At the moment, no, nothing is written back to them. They should contain the values of the width and height of the texture passed in (and pretty much currently must be 1024 and at least 512 respectively).

[PH3NOM]

Two quick questions:

- Why is the src argument in void * sq_cpy(void *dest, void *src, int n) not const? Can sq_cpy change src?

No, it can not. It should be const, but it was traditionally not so. I'll probably change that at some point (as well as making n a size_t instead of an int, since it should never be negative), but as I said, that is not how it was originally written for whatever reason.

As it really should be a cont pointer, I went ahead and made that change in the repo today when adding some kgl stuff.
Git the latest commit to check things out.